Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

Not allowing semicolon in parameterised fields.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh amoghrajesh merged commit e6c0793 into apache:main Mar 22, 2025
62 checks passed
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Mar 22, 2025
@hartwork
Copy link

hartwork commented Apr 4, 2025

FYI this pull request was mentioned as associated with CVE-2025-30473 at https://www.openwall.com/lists/oss-security/2025/04/04/2 . Please consider adding "CVE-2025-30473" to the pull request title 🙏

@eladkal
Copy link
Contributor

eladkal commented Apr 4, 2025

Please consider adding "CVE-2025-30473" to the pull request title

What for?

@hartwork
Copy link

hartwork commented Apr 4, 2025

Visibility, transparency.

@potiuk
Copy link
Member

potiuk commented Apr 4, 2025

Visibility, transparency.

Well. Changing title of PR after it's merged is wrong and it expects an extra effort on maintainers who do it in their free time.

And we cannot refer to CVE before we announce it, and when you look at CVE announcement you have link to the PR. I think it's good enough.

If you think you might want to increase visibility, I suggest you start your own project where you keep the links between CVE and PRs even more transparency. That would be a great relief for maintainers who do a lot of the work in their free time to keep your usage of the open-source projects they maintain secure.

Would you like to start such a project? That would be greatly appreciated by all the open source maintainers who make their software available for free - mostly in their free time away from their families and other day job,

Can we (open-source community) count on your help there @hartwork ?

@potiuk
Copy link
Member

potiuk commented Apr 4, 2025

I think the whole community will thank you for that - here is your chance to actually contribute @hartwork

@hartwork
Copy link

hartwork commented Apr 4, 2025

@potiuk all my work on Open Source including libexpat is unpaid voluntary work including the security stuff and I do keep CVEs in pull request titles there if you would like to check: https://github.com/libexpat/libexpat/pulls?q=is%3Apr+is%3Aclosed+CVE . Does that change the picture for you?

nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
@potiuk
Copy link
Member

potiuk commented Apr 5, 2025

Does that change the picture for you?

No. You are free to do what you want and spend as much time as you want on it. It's your free tiime to spend and it's you to decide what to do with it. Similarly, we decided what to do with our time,

@ug0x01
Copy link

ug0x01 commented Jun 12, 2025

Hi, I want to reproduce the issue but I'm not that familier with airflow and couldn't find where SQLColumnCheckOperator class is being called in the project. Can you please send reproduce steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants